-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix phpstan baseline, eslint config and caching tests #6493
Fix phpstan baseline, eslint config and caching tests #6493
Conversation
{ | ||
"props": "never", | ||
"children": "never", | ||
"propElementValues": "always" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new but it is as stated in the following issue / comment jsx-eslint/eslint-plugin-react#3228 (comment) not supported by all parser so we need to define it to always so our parsers do not have problems with it.
@@ -38,6 +38,7 @@ public function testFirstRequestIsACacheMiss() | |||
$cacheKernel = new AppCache(self::bootKernel()); | |||
$cookieJar = new CookieJar(); | |||
$client = new KernelBrowser($cacheKernel, [], null, $cookieJar); | |||
$client->disableReboot(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is now required else other tests are running into an issue about a not booted kernel
protected static function getKernelClass(): string | ||
{ | ||
return S3Kernel::class; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
required because of: symfony/symfony#45414
We still need to define protected static $class = S3Kernel::class;
for prefer lowest tests.
What's in this PR?
Fix phpstan baseline.
Why?
Fix baseline.